release: build multi-arch docker image #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gandem
force-pushed
the
nayef/dockerfile
branch
23 times, most recently
from
65d4c3b
to
8e15a72
Compare
Gandem
force-pushed
the
nayef/dockerfile
branch
from
1b148c3
to
78cf52a
Compare
Gandem
force-pushed
the
nayef/dockerfile
branch
from
78cf52a
to
4480eb6
Compare
Gandem
force-pushed
the
nayef/dockerfile
branch
2 times, most recently
from
4a47e01
to
6c7012e
Compare
|
I was going to suggest to only publish docker image in the release workflow, but it seems you just did the change :) |
|
Yes! Was just putting it in the build workflow to test more easily, since it took me quite a few iterations to get something working 😄 |
|
🤓 nitpick: Maybe add a wrapper around otel-profiling-agent that checks that debugfs is mounted and attempts to mount it otherwise. |
nsavoire
approved these changes
Aug 13, 2024
Gandem
force-pushed
the
nayef/dockerfile
branch
2 times, most recently
from
c1e209d
to
d67707b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container image is published to: https://github.com/DataDog/otel-profiling-agent/pkgs/container/otel-profiling-agent
Tested locally and the agent is running just fine:
Jira: https://datadoghq.atlassian.net/browse/PROF-10354