uploads: update compression to zstd #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gandem
force-pushed
the
nayef/update-compression
branch
4 times, most recently
from
56d395b
to
8d0a5c4
Compare
felixge
approved these changes
Aug 30, 2024
nsavoire
approved these changes
Sep 2, 2024
Gandem
force-pushed
the
nayef/update-compression
branch
from
8d0a5c4
to
5664128
Compare
Yes, profiles are available in the UI, and the intake is forwarding them as is (as shown by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update compression to zstd for profile and symbol upload with the goal of reducing network traffic.
Since we're sending a multi-part attachment with a small event (metadata) and a large file (pprof/symbols), with our current backend implementation, it's preferable to only compress the large payload to reduce costs.
However, since handling a compressed file is only supported for profiles and not symbols, we:
@DataDog/profiling-full-host
https://datadoghq.atlassian.net/browse/PROF-10408