Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuhh case study #1

Merged
merged 15 commits into from
Jul 1, 2024
Merged

Tuhh case study #1

merged 15 commits into from
Jul 1, 2024

Conversation

BenjaminArp
Copy link
Contributor

No description provided.

@BenjaminArp
Added Case Study models from TUHH
4510bee 
 DD&DFD: DFA representation
Json: converted plantuml reprsentation of TUHH
@BenjaminArp
removing out of scope models
4bd6d34
@BenjaminArp BenjaminArp requested a review from uuqjz June 26, 2024 12:17
@uuqjz uuqjz mentioned this pull request Jun 29, 2024
Merged
3 tasks
@BenjaminArp
Copy link
Contributor Author

BenjaminArp commented Jun 29, 2024 •
edited
Loading

Todo
-[] merge (DataFlowAnalysis/Converter#8) and rerun pipeline

afterwards ready to merge

@uuqjz uuqjz requested a review from Nicolas-Boltz July 1, 2024 07:57
Nicolas-Boltz
Nicolas-Boltz requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the folder "CaseStudies" to lower case to fit with the other naming conventions.
Also, to make everything consistent, you should maybe also move the case study models (CWA, MaaS, TP) from the models folder to the casestudies folder.

@uuqjz uuqjz requested a review from Nicolas-Boltz July 1, 2024 08:20
Nicolas-Boltz
Nicolas-Boltz approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicolas-Boltz Nicolas-Boltz merged commit 8912830 into main Jul 1, 2024
1 check passed
@Nicolas-Boltz Nicolas-Boltz deleted the TUHH-CaseStudy branch July 1, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicolas-Boltz Nicolas-Boltz Nicolas-Boltz approved these changes

@uuqjz uuqjz Awaiting requested review from uuqjz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjaminArp @Nicolas-Boltz @uuqjz