-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Restore Substrate pallets for on-chain upgrade that were temporarily removed to minimise genesis runtime size for Rococo launch #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ltfschoen Where did you generate res/rococo-parachain-raw.json
file? On server or on local?
good point, yes we should generate that on the server and put a copy of it here |
Yes, Please generate fresh files on |
i've made a commit that now includes the files that were generated on Spreehafen |
Restore Substrate pallets that were removed to minimize runtime size for Rococo genesis launch. As part of launching on the Rococo parachain production testnet in this previous PR that was merged feat: Migrate pallets from standalone chain that was updated to common branch 'polkadot-v0.9.17' progressively #17, a recommendation was to minimise the runtime size and then perform incremental runtime upgrades to reintroduce the funcitonality.
Previously in that PR we removed the following Substrate pallets in the following commits: e6edf89, 7a0810d, 676e96b
These pallets have been restored in this PR using git revert.
Update versions in Cargo.toml files for and other parameters like
spec_version
andimpl_version
check that all essential pallet functionality works using polkadot.js
Linting to fix indentation issues
cargo build --release --features runtime-benchmarks
, as it gives the following erorr even though we're not evening using frame society, and even thoughsuccessful_origin
is already implemented in that branch here https://github.com/paritytech/substrate/blob/22d40c7/frame/society/src/lib.rs#L1278- check that unit and integration tests still pass
SKIPPED - Memory Profiling. See notes in feat: Migrate pallets from standalone chain that was updated to common branch 'polkadot-v0.9.17' progressively #17
SKIPPED - Try-runtime. See notes in feat: Migrate pallets from standalone chain that was updated to common branch 'polkadot-v0.9.17' progressively #17
SKIPPED - Benchmarking. See notes in feat: Migrate pallets from standalone chain that was updated to common branch 'polkadot-v0.9.17' progressively #17
Updates to incorporate changes from Substrate branch 'polkadot-v0.9.17' to 'polkadot-v0.9.18' that affected those pallets
Fix benchmarking script
Increment
spec_version
to3
Increment version of runtime and node from 3.4.0 to 3.5.0
Performed the following on the Rococo server (not local machine)
Generate new Github release (use contents of this checklist to mention what was done) and perform runtime upgrade on Rococo. Add DRAFT RELEASE MESSAGE below