-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Column spans #1736
base: master
Are you sure you want to change the base?
feat: Column spans #1736
Conversation
b23d917
to
a893e72
Compare
|
Can you add a test? |
Sure, I just have limited resources and vacation soon, so if someone wants to finish up, I don't mind. |
a893e72
to
dc20c86
Compare
I added a test, but it does not precisely check e.g. the different box properties. |
I have a small problem: the tests now complain, that there's a difference (which is indeed in the renders). I suspect the test renderer interprets this as small gap and therefore outputs the mean as grey? Should we ignore this or solve it another way? |
Yes, that's possible. Seems to be at the intersection of each cell. |
To allow col spans the border must be calculated for each cell and not for the whole width / height of the table any more. So there now exist infinite small fake gaps, which in theory should not be visible, and also aren't in my inspection in the pdf readers, just the pdftocairo does this I think... |
That's fine then. |
I now wonder, if it would make sense to introduce a new widget, like See also: |
Add's the colspan feature for table rows.
Closes #989, #896, #645, #313, #256, #167