Skip to content

Commit

Permalink
Merge branch 'v3' into mkdocs-baseline
Browse files Browse the repository at this point in the history
  • Loading branch information
DaveSkender authored Jan 6, 2025
2 parents 3097980 + 9448c8e commit 78c80c8
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 97 deletions.
9 changes: 1 addition & 8 deletions .github/workflows/deploy-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
if [[ "${{ inputs.environment }}" == "nuget.org" ]]; then
echo "pkg_url=https://www.nuget.org/packages/${PACKAGE_NAME}/${{ steps.version_info.outputs.version }}" >> $GITHUB_OUTPUT
else
echo "pkg_url=https://github.com/${{ github.repository }}/packages/nuget/${PACKAGE_NAME}/${{ steps.version_info.outputs.version }}" >> $GITHUB_OUTPUT
echo "pkg_url=https://github.com/${{ github.repository }}/pkgs/nuget/${PACKAGE_NAME}" >> $GITHUB_OUTPUT
fi
- name: Build library
Expand Down Expand Up @@ -155,13 +155,6 @@ jobs:
dotnet-version: "9.x"
dotnet-quality: "ga"

- name: Setup NuGet
uses: nuget/setup-nuget@v2
with:
nuget-api-key: ${{ secrets.NUGET_TOKEN }}
nuget-version: '6.x'


- name: Download package
uses: actions/download-artifact@v4
with:
Expand Down
63 changes: 37 additions & 26 deletions .github/workflows/lint-pull-request.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Pull request

on:
pull_request_target:
pull_request:
types:
- opened
- edited
- synchronize
- unlabeled

permissions:
pull-requests: write
Expand All @@ -21,49 +21,60 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:

# Configure additional validation for the subject based on a regex.
# We enforce that the subject starts with an uppercase character.
subjectPattern: ^([A-Z]).+$

# If `subjectPattern` is configured, you can use this property to override
# the default error message that is shown when the pattern doesn't match.
# The variables `subject` and `title` can be used within the message.
subjectPatternError: >
The subject "**{subject}**" in pull request "*{title}*"
needs to start with an uppercase character.
# If the PR contains one of these newline-delimited labels, the
# validation is skipped. If you want to rerun the validation when
# labels change, you might want to use the `labeled` and `unlabeled`
# event triggers in your workflow.
The subject "**{subject}**" must start with an uppercase character.
Example: "Add feature" instead of "add feature"
ignoreLabels: |
bot
dependencies
- uses: marocchino/sticky-pull-request-comment@v2
# When the previous steps fails, the workflow would stop. By adding this
# condition you can continue the execution with the populated error message.
if: always() && (steps.lint_pr_title.outputs.error_message != null)
with:
header: pr-title-lint-error
message: |
### ⚠️ Pull Request title needs adjustment
### ⚠️ Invalid Pull Request title
Your PR title doesn't match our naming convention: `type: Subject`
Your PR title must follow the format: `type: Subject` where:
- `type` is one of the conventional commit types (in lowercase)
- `Subject` starts with an uppercase letter
> [!CAUTION]
> ${{ steps.lint_pr_title.outputs.error_message }}
#### Valid examples
- `feat: Add new RSI indicator`
- `fix: Correct MACD calculation`
- `chore: Update documentation`
- `test: Add unit tests for EMA`
- `refactor: Optimize moving average logic`
- `feat: Add API endpoint for market data`
- `fix: Resolve WebSocket connection issues`
- `chore: Update NuGet dependencies`
<details>
<summary>see more valid examples</summary>
#### Features & fixes
- `feat: Add API endpoint for market data`
- `fix: Resolve WebSocket connection issues`
#### Code quality
- `style: Format trading strategy classes`
- `refactor: Restructure trading engine components`
- `perf: Optimize trade order execution flow`
#### Documentation & testing
- `docs: Update API documentation`
- `test: Add unit tests for sign-in flow`
#### Infrastructure
- `build: Update .NET SDK version to 8.0`
- `ci: Add workflow for performance testing`
- `chore: Update NuGet dependencies`
#### Other
- `revert: Remove faulty market data provider`
See the [Conventional Commits specification](https://www.conventionalcommits.org) for more information.
See [Conventional Commits](https://www.conventionalcommits.org) for more details.
</details>
# Delete a previous comment when the issue has been resolved
- if: ${{ steps.lint_pr_title.outputs.error_message == null }}
Expand Down
52 changes: 0 additions & 52 deletions .github/workflows/test-codeql.yml

This file was deleted.

21 changes: 10 additions & 11 deletions .github/workflows/test-indicators.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Indicators
name: Test Indicators

on:
push:
branches: ["main"]

pull_request:
branches: ["*"]
workflow_dispatch:

jobs:
test:
Expand All @@ -20,19 +20,17 @@ jobs:
strategy:
matrix:
os: [windows-latest, ubuntu-latest, macos-latest]
dotnet-version: ["9.x"]
# TODO: restore when GitHub Action runners
# have .NET 9.x SDK default installed
# ["2.1.x", "6.x", "9.x"]
dotnet-version: ["6.0.x", "9.0.x"]

env:

# identifying primary configuration so only one reports coverage
IS_PRIMARY: ${{ matrix.os == 'ubuntu-latest' && matrix.dotnet-version == '9.x' }}
IS_PRIMARY: ${{ matrix.os == 'ubuntu-latest' && matrix.dotnet-version == '9.0.x' }}

# .NET SDK versions in the matrix that support
# `dotnet-quality: 'ga'`, not supported before 5.x
SUPPORT_GA: ${{ contains(fromJson('["6.x", "9.x"]'), matrix.dotnet-version) }}
# Identifies the current target framework
TARGET_FRAMEWORK: >
${{ matrix.dotnet-version == '6.0.x' && 'net6.0' ||
matrix.dotnet-version == '9.0.x' && 'net9.0' }}
steps:

Expand All @@ -42,7 +40,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: ${{ matrix.dotnet-version }}
dotnet-version: "9.x"
dotnet-quality: "ga"

- name: Build library
Expand All @@ -58,6 +56,7 @@ jobs:
--configuration Release
--settings tests/tests.unit.runsettings
--results-directory ./test-results
--property:TestFramework="${{ env.TARGET_FRAMEWORK }}"
--no-build
--verbosity normal
--logger trx
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ _TeamCity*
*.coverage
*.coveragexml

# Visual Studio live unit testing
*.lutconfig

# NCrunch
_NCrunch_*
.*crunch*.local.xml
Expand Down

0 comments on commit 78c80c8

Please sign in to comment.