Merge branch 'v3-increments' into 'v3-increments-atrstop'

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -0,0 +1,39 @@
+name: Bug report
+description: File a bug report.
+labels: ["bug"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you 💖 for taking the time report a bug in the [Skender.Stock.Indicators NuGet library](https://www.nuget.org/packages/Skender.Stock.Indicators)!
+        > Please review known [issues](https://github.com/DaveSkender/Stock.Indicators/issues?q=is%3Aissue), community [discussions](https://github.com/DaveSkender/Stock.Indicators/discussions), and [Help! Results don't match TradingView!](https://github.com/DaveSkender/Stock.Indicators/discussions/801) before submitting a new bug report.
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: What happened?
+      description: What did you expect to happen?
+      placeholder: Tell us what you see!
+    validations:
+      required: true
+  - type: textarea
+    id: usage
+    attributes:
+      label: Code usage
+      description: How did you write your code? Provide a code snippet. _This will be auto-formatted as code, so no need for \`backticks\`_. Also, consider providing your source _quotes_ as a _JSON, CSV, or Excel_ file in the "What happened?" field.
+      render: csharp
+      placeholder: |
+        // example (put your own code here)
+        IEnumerable<EmaResult> results = quotes.GetEma(14);
+    validations:
+      required: false
+  - type: textarea
+    id: logs
+    attributes:
+      label: Log output
+      description: Please copy and paste any relevant log output. _This will be auto-formatted as code, so no need for \`backticks\`_.
+      render: bash
+    validations:
+      required: false
+  - type: markdown
+    attributes:
+      value: If your request is urgent, please review our [sponsorship tiers](https://github.com/sponsors/facioquo). For contract custom development, contact [Skender Co.](https://skenderco.com)

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -0,0 +1,36 @@
+name: Feature request
+description: Suggest an idea for this project.
+labels: ["enhancement"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you 💖 for taking the time to make a recommendation for the [Skender.Stock.Indicators NuGet library](https://www.nuget.org/packages/Skender.Stock.Indicators)! If you have an idea that you don't want us to track in [our backlog](https://github.com/users/DaveSkender/projects/1), consider posting in our community [discussions](https://github.com/DaveSkender/Stock.Indicators/discussions).
+  - type: textarea
+    id: request
+    attributes:
+      label: the problem
+      description: What problem are you trying to solve? Or, what outcome do you want achieve? Why?
+      placeholder: I'm always frustrated when [...]
+    validations:
+      required: true
+  - type: textarea
+    id: solution
+    attributes:
+      label: an idea
+      description: Any suggestions for a solution? Include any alternative solutions you've considered. If requesting a new [reputable indicator](https://github.com/DaveSkender/Stock.Indicators/discussions/1024), please provide the original author's publication of its recipe.
+      placeholder: I'd love it if the library could [...]
+    validations:
+      required: false
+  - type: textarea
+    id: usage
+    attributes:
+      label: code example
+      description: Any proposed implementation syntax? _This will be auto-formatted as code, so no need for \`backticks\`_.
+      render: shell
+      placeholder: var foo = quotes.AwesomeNewFeature(whatDaYaThink);
+    validations:
+      required: false
+  - type: markdown
+    attributes:
+      value: If your request is urgent, please review our [sponsorship tiers](https://github.com/sponsors/facioquo). For contract custom development, contact [Skender Co.](https://skenderco.com)

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,26 +1,4 @@
-<!-- some optional templates:
-
 #### done when
 
-- [ ] Implement X
-- [ ] Implement Y
-- [ ] Fix: #1234
-
-or a simply:
-
-Fixes:
-
-- #1234 <-- add related issue number(s) as bullet list
-
-If helpful, also include this checklist to communicate what you've done
-to prepare this Pull Request for acceptance.
-
-### self-review checklist
-
-- [ ] My code follows the existing style, code structure, and naming taxonomy
-- [ ] I have put comments in my code, particularly for hard-to-understand areas
-- [ ] I have performed a self-review of my code and included any verifying manual calculations
-- [ ] I have added or updated unit tests that prove my code is effective and covered
-- [ ] My changes generate no new warnings or other code analysis issues
-- [ ] I have made corresponding changes to the documentation
--->
+- [ ] Implement
+- [ ] Fix: #

.github/workflows/deploy-package.yml

@@ -35,14 +35,14 @@ jobs:
           fetch-depth: 0
 
       - name: Setup GitVersion
-        uses: gittools/actions/gitversion/setup@v1.1.1
+        uses: gittools/actions/gitversion/setup@v1.2.0
         with:
           versionSpec: "5.x"
           preferLatestVersion: true
 
       - name: Determine version
         id: gitversion
-        uses: gittools/actions/gitversion/execute@v1.1.1
+        uses: gittools/actions/gitversion/execute@v1.2.0
         with:
           updateAssemblyInfo: true
           useConfigFile: true

.github/workflows/test-examples.yml

@@ -10,7 +10,7 @@ on:
     branches: ["main","v3"]
     paths:
       - docs/examples/**
-      - ".github/workflows/build-examples.yml"
+      - ".github/workflows/test-examples.yml"
 
 jobs:
   build:

.github/workflows/test-performance.yml

@@ -17,14 +17,14 @@ jobs:
           fetch-depth: 0
 
       - name: Setup GitVersion
-        uses: gittools/actions/gitversion/setup@v1.1.1
+        uses: gittools/actions/gitversion/setup@v1.2.0
         with:
           versionSpec: "5.x"
           preferLatestVersion: true
 
       - name: Determine version
         id: gitversion
-        uses: gittools/actions/gitversion/execute@v1.1.1
+        uses: gittools/actions/gitversion/execute@v1.2.0
         with:
           updateAssemblyInfo: true
           useConfigFile: true
@@ -41,7 +41,6 @@ jobs:
           dotnet build
           --configuration Release
           --property:ContinuousIntegrationBuild=true
-          -warnAsError
 
       - name: Benchmark indicators
         working-directory: tests/performance
@@ -59,7 +58,7 @@ jobs:
           echo "### Package version ${{ steps.gitversion.outputs.fullSemVer }}" >> $GITHUB_STEP_SUMMARY
 
           echo "## Static indicators" >> $GITHUB_STEP_SUMMARY
-          cat Tests.Performance.IndicatorStaticTests-report-github.md >> $GITHUB_STEP_SUMMARY
+          cat Performance.SeriesIndicators-report-github.md >> $GITHUB_STEP_SUMMARY
 
           echo "## Stream indicators (with Quote caching)" >> $GITHUB_STEP_SUMMARY
-          cat Tests.Performance.IndicatorStreamTests-report-github.md >> $GITHUB_STEP_SUMMARY
+          cat Performance.StreamIndicators-report-github.md >> $GITHUB_STEP_SUMMARY

.github/workflows/test-website-a11y.yml

@@ -7,7 +7,7 @@ on:
     branches: ["main"]
     paths:
       - 'docs/**'
-      - ".github/workflows/docs-test-a11y.yml"
+      - ".github/workflows/test-website-a11y.yml"
 
 env:
   JEKYLL_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/test-website-links.yml

@@ -7,7 +7,7 @@ on:
     branches: ["main"]
     paths:
       - 'docs/**'
-      - ".github/workflows/docs-test-links.yml"
+      - ".github/workflows/test-website-links.yml"
 
 env:
   JEKYLL_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

docs/GemFile.lock

@@ -18,8 +18,8 @@ GEM
       minitest (>= 5.1)
       mutex_m
       tzinfo (~> 2.0)
-    addressable (2.8.6)
-      public_suffix (>= 2.0.2, < 6.0)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
     base64 (0.2.0)
     bigdecimal (3.1.8)
     coffee-script (2.4.1)
@@ -31,7 +31,7 @@ GEM
     concurrent-ruby (1.3.3)
     connection_pool (2.4.1)
     cssminify2 (2.0.1)
-    dnsruby (1.72.1)
+    dnsruby (1.72.2)
       simpleidn (~> 0.2.1)
     drb (2.2.1)
     em-websocket (0.5.3)
@@ -40,8 +40,9 @@ GEM
     ethon (0.16.0)
       ffi (>= 1.15.0)
     execjs (2.9.1)
-    faraday (2.9.2)
+    faraday (2.10.0)
       faraday-net_http (>= 2.0, < 3.2)
+      logger
     faraday-net_http (3.1.0)
       net-http
     faraday-retry (2.2.1)
@@ -235,12 +236,13 @@ GEM
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
+    logger (1.6.0)
     mercenary (0.3.6)
     minima (2.5.1)
       jekyll (>= 3.5, < 5.0)
       jekyll-feed (~> 0.9)
       jekyll-seo-tag (~> 2.1)
-    minitest (5.24.0)
+    minitest (5.24.1)
     mutex_m (0.2.0)
     net-http (0.4.1)
       uri
@@ -258,7 +260,7 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.11.1)
       ffi (~> 1.0)
-    rexml (3.3.0)
+    rexml (3.3.2)
       strscan
     rouge (3.30.0)
     rubyzip (2.3.2)

src/GlobalSuppressions.cs

@@ -25,17 +25,7 @@
     Scope = "member",
     Target = "~F:Skender.Stock.Indicators.ChandelierType.Short")]
 
-[assembly: SuppressMessage(
-    "Style",
-    "IDE0056:Use index operator",
-    Justification = "Does not support .NET Standard.")]
-
 [assembly: SuppressMessage(
     "Maintainability",
     "CA1510:Use ArgumentNullException throw helper",
     Justification = "Can only use with .NET 6 or later.  We support .NET Framework and .NET Standard.")]
-
-[assembly: SuppressMessage(
-    "StyleCop.CSharp.SpacingRules",
-    "SA1010:Opening square brackets should be spaced correctly",
-    Justification = "Invalid for new C# 12 [ collection ] syntax.")]

src/_common/Globals.cs

@@ -2,7 +2,7 @@
 using System.Runtime.CompilerServices;
 
 [assembly: CLSCompliant(true)]
-[assembly: InternalsVisibleTo("Tests.Indicators")]
+[assembly: InternalsVisibleTo("Tests.Indicators")]  // these test internals
 [assembly: InternalsVisibleTo("Tests.Performance")]
 
 namespace Skender.Stock.Indicators;

tests/application/Program.cs

@@ -26,8 +26,7 @@ public class Do
 
     private static readonly QuoteHub<Quote> provider = new();
 
-    private static readonly IReadOnlyList<Quote> quotesList
-        = TestData.GetDefault().ToSortedCollection();
+    private static readonly IReadOnlyList<Quote> quotesList = Data.Data.GetDefault();
 
     private static readonly int quotesLength = quotesList.Count;
 

tests/application/Test.Application.csproj

@@ -11,19 +11,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <None Update="_testdata\data\compare.csv">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
-    <None Update="_testdata\data\default.csv">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
-    <None Update="_testdata\data\intraday.csv">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
-    <None Update="_testdata\data\longest.csv">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
-    <None Update="_testdata\data\longish.csv">
+    <None Update="_testdata\data\*.csv">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
   </ItemGroup>