Merge branch 'main' into inject-release-notes

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,32 +1,17 @@
----
-title: ""
----
-<!--
-Use a conventional commit standard pull-request title,
-like 'feat: My new feature' or 'fix: Div/zero in X calculation'
--->
-
-### description of change
-
-<!--
-Please include a summary of the change and which issue is fixed.
-Include relevant motivation, context, and sources of information or recipes.
-Use a To Do "done when" list if helpful; example:
+<!-- some optional templates:
 
 #### done when
 
 - [ ] Implement X
 - [ ] Implement Y
-- [ ] Fix: #123
+- [ ] Fix: #1234
 
 or a simply:
 
 Fixes:
 
-- # <-- add issue number(s) as a rendered list
--->
+- #1234 <-- add related issue number(s) as bullet list
 
-<!--
 If helpful, also include this checklist to communicate what you've done
 to prepare this Pull Request for acceptance.
 
@@ -39,12 +24,3 @@ to prepare this Pull Request for acceptance.
 - [ ] My changes generate no new warnings or other code analysis issues
 - [ ] I have made corresponding changes to the documentation
 -->
-
-<!--
-We also recommend creating the pull request as early as possible,
-in Draft status.  This will allow you to log any discoveries along
-the way as comments in the body of this pull request and to have
-conversations with others for early feedback (optional).
-
-Please delete these hidden explanatory comments when submitting.
--->

.github/workflows/test-indicators.yml

@@ -14,7 +14,8 @@ jobs:
 
     permissions:
       contents: read
-      pull-requests: write
+      actions: read
+      checks: write
 
     strategy:
       matrix:
@@ -82,14 +83,12 @@ jobs:
           --results-directory ./test-other
 
       - name: Post test summary
-        uses: bibipkins/dotnet-test-reporter@v1.4.1
+        uses: dorny/test-reporter@v1
         if: env.IS_PRIMARY == 'true' && always()
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          comment-title: ""
-          results-path:  ./test-indicators/**/*.trx
-          coverage-path: ./test-indicators/**/coverage.cobertura.xml
-          coverage-type: cobertura
+          name: Test results
+          path: ./test-indicators/**/*.trx
+          reporter: dotnet-trx
 
       - name: Publish coverage to Codacy
         uses: codacy/codacy-coverage-reporter-action@v1

tests/indicators/Tests.Indicators.csproj

@@ -15,8 +15,8 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
-    <PackageReference Include="MSTest.TestAdapter" Version="3.4.0" />
-    <PackageReference Include="MSTest.TestFramework" Version="3.4.0" />
+    <PackageReference Include="MSTest.TestAdapter" Version="3.4.3" />
+    <PackageReference Include="MSTest.TestFramework" Version="3.4.3" />
     <PackageReference Include="coverlet.collector" Version="6.0.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

tests/other/Tests.Other.csproj

@@ -15,8 +15,8 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
-    <PackageReference Include="MSTest.TestAdapter" Version="3.4.0" />
-    <PackageReference Include="MSTest.TestFramework" Version="3.4.0" />
+    <PackageReference Include="MSTest.TestAdapter" Version="3.4.3" />
+    <PackageReference Include="MSTest.TestFramework" Version="3.4.3" />
   </ItemGroup>
 
   <ItemGroup>