other observer related merge fixes

DaveSkender · Jan 3, 2024 · e38bbad · e38bbad
1 parent af0251e
commit e38bbad
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 21 deletions.
diff --git a/src/GlobalSuppressions.cs b/src/GlobalSuppressions.cs
@@ -63,4 +63,4 @@
     "Naming",
     "CA1716:Identifiers should not match keywords",
     Justification = "The microsoft OnError implementation uses reserved word Error",
-    Scope = "member", Target = "~M:Skender.Stock.Indicators.TupleObserver.OnError(System.Exception)")]
+    Scope = "member", Target = "~M:Skender.Stock.Indicators.TupleObserver.OnError(System.Exception)")]
diff --git a/src/_common/Observables/ChainProvider.cs b/src/_common/Observables/ChainProvider.cs
@@ -11,8 +11,8 @@ public abstract class ChainProvider
     // initialize
     protected ChainProvider()
     {
-        observers = new();
-        ProtectedChain = new();
+        observers = [];
+        ProtectedChain = [];
         Warmup = true;
     }
 

diff --git a/src/_common/Observables/QuoteProvider.cs b/src/_common/Observables/QuoteProvider.cs
@@ -10,8 +10,8 @@ public class QuoteProvider : IObservable<Quote>
     // initialize
     public QuoteProvider()
     {
-        observers = new();
-        ProtectedQuotes = new();
+        observers = [];
+        ProtectedQuotes = [];
     }
 
     // properties

diff --git a/src/_common/Observables/TupleProvider.cs b/src/_common/Observables/TupleProvider.cs
@@ -11,8 +11,8 @@ public abstract class TupleProvider
     // initialize
     protected TupleProvider()
     {
-        observers = new();
-        ProtectedTuples = new();
+        observers = [];
+        ProtectedTuples = [];
     }
 
     // properties

diff --git a/src/e-k/Ema/Ema.Observer.cs b/src/e-k/Ema/Ema.Observer.cs
@@ -9,7 +9,7 @@ public EmaObserver(
         int lookbackPeriods)
     {
         Supplier = provider;
-        ProtectedResults = new();
+        ProtectedResults = [];
 
         LookbackPeriods = lookbackPeriods;
         K = 2d / (lookbackPeriods + 1);

diff --git a/src/s-z/Sma/Sma.Observer.cs b/src/s-z/Sma/Sma.Observer.cs
@@ -9,7 +9,7 @@ public SmaObserver(
         int lookbackPeriods)
     {
         Supplier = provider;
-        ProtectedResults = new();
+        ProtectedResults = [];
 
         LookbackPeriods = lookbackPeriods;
 
@@ -65,17 +65,12 @@ internal static double Increment(
     // add new tuple quote
     internal void Add((DateTime Date, double Value) tp)
     {
-        if (Supplier == null)
-        {
-            throw new ArgumentNullException(nameof(Supplier), "Could not find data source.");
-        }
-
         // candidate result
         SmaResult r = new(tp.Date);
 
         // initialize
         int lengthRes = ProtectedResults.Count;
-        int lengthSrc = Supplier.ProtectedTuples.Count;
+        int lengthSrc = Supplier!.ProtectedTuples.Count;  // merge fix, okay to replace
 
         // handle first value
         if (lengthRes == 0)

diff --git a/tests/observe/Program.cs b/tests/observe/Program.cs
@@ -7,7 +7,7 @@ internal class Program
 {
     private static async Task Main(string[] args)
     {
-        if (args.Any())
+        if (args.Length != 0)
         {
             Console.WriteLine(args);
         }
@@ -56,10 +56,8 @@ IAlpacaCryptoStreamingClient client
 
         await client.ConnectAndAuthenticateAsync();
 
-        AutoResetEvent[] waitObjects = new[]  // todo: is this needed?
-        {
-            new AutoResetEvent(false)
-        };
+        // todo: is this needed?
+        AutoResetEvent[] waitObjects = [new AutoResetEvent(false)];
 
         IAlpacaDataSubscription<IBar> quoteSubscription
             = client.GetMinuteBarSubscription(symbol);
@@ -114,4 +112,4 @@ IAlpacaDataSubscription<IBar> quoteSubscription
             Console.WriteLine($"{symbol} {s.Date:s} ${s.Sma:N2}");
         }
     }
-}
+}