Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Highs New Lows indicator #1032

Closed
wants to merge 11 commits into from

Conversation

gugavaro
Copy link

@gugavaro gugavaro commented Feb 20, 2023

Description

New indicator for New Highs New Lows

Implements #1004

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender
Copy link
Owner

I'll take a look when I have a chance to spend enough time reviewing (and working on the chart). That could take several weeks to set some expectations. For now, do what you can to resolve any of the build errors.

@DaveSkender DaveSkender changed the title Adding New Highs New Lows indicator add New Highs New Lows indicator Feb 20, 2023
@gugavaro
Copy link
Author

I'll take a look when I have a chance to spend enough time reviewing (and working on the chart). That could take several weeks to set some expectations. For now, do what you can to resolve any of the build errors.

Thanks, I will take a look on the build errors and try to fix it!

@DaveSkender
Copy link
Owner

One new aspect of this that I’ll want to spend time on is the multi-quote aspect, to make sure it’s solid. This sorta opens the door to more portfolio types of indicators, so I’m excited that you brought this to us.

We touch on this with Beta, Correlation, and a few more where you need two for comparison, but not for large bundles. It’s interesting.

@DaveSkender DaveSkender changed the title add New Highs New Lows indicator feat: New Highs New Lows indicator Jan 1, 2024
@DaveSkender DaveSkender marked this pull request as draft January 14, 2024 15:54
@DaveSkender DaveSkender added the stale May be removed if not prioritized label Oct 28, 2024
@DaveSkender
Copy link
Owner

Closing due to staleness. Resubmit when ready.

@DaveSkender DaveSkender closed this Nov 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale May be removed if not prioritized
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants