Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Heikin-Ashi docs #1161

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: Heikin-Ashi docs #1161

merged 2 commits into from
Feb 2, 2024

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Feb 2, 2024

During evaluation of #1160 I found an error in our Heikin-Ashi documentation. The first set of values is no longer null as there is a reasonable starting result based on the initial candle value.

To do:

  • remove reference that indicates the first period would be null
  • refactor code to only evaluate first period once. This should provide a slightly better performance.

Signed-off-by: Dave Skender <[email protected]>
Copy link

github-actions bot commented Feb 2, 2024

✔️ Tests 718 / 718 - passed in 6.4s
📝 Coverage 96.57%
📏 5311 / 5314 lines covered 🌿 2296 / 2563 branches covered
🔍 click here for more details

✏️ updated for commit 70e1659

@DaveSkender DaveSkender marked this pull request as ready for review February 2, 2024 23:26
@DaveSkender
Copy link
Owner Author

This micro-optimization for initialization improved the performance test by 0.001us :neckbeard: No difference, really. Still, seems like a better practices so each iterative loop isn't re-evaluating condition.

@DaveSkender DaveSkender merged commit 74a8f34 into main Feb 2, 2024
12 checks passed
@DaveSkender DaveSkender deleted the DaveSkender-patch-1 branch February 2, 2024 23:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant