Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Max cache size for StreamHub #1290

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender self-assigned this Dec 15, 2024
@DaveSkender DaveSkender marked this pull request as ready for review December 16, 2024 04:47
@DaveSkender DaveSkender linked an issue Dec 16, 2024 that may be closed by this pull request
2 tasks
@DaveSkender DaveSkender requested a review from Copilot December 16, 2024 04:51

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/_common/Observables/StreamHub.cs: Evaluated as low risk
  • src/_common/Quotes/Quote.StreamHub.cs: Evaluated as low risk
Comments suppressed due to low confidence (4)

src/_common/Observables/StreamHub.Observable.cs:101

  • The new behavior introduced by NotifyObserversOnRebuild should be covered by tests.
private void NotifyObserversOnRebuild(DateTime fromTimestamp)

src/_common/Observables/StreamHub.Observable.cs:113

  • The new behavior introduced by NotifyObserversOnPrune should be covered by tests.
private void NotifyObserversOnPrune(DateTime toTimestamp)

src/_common/Observables/StreamHub.Observer.cs:42

  • Ensure that the PrunedCache test method in StreamHub.CacheMgmt.Tests.cs covers the behavior of the OnPrune method.
public void OnPrune(DateTime toTimestamp)

tests/indicators/_common/Observables/StreamHub.CacheMgmt.Tests.cs:203

  • The test method 'PrunedAsymmetric' is marked as inconclusive. It should either be implemented or removed if not relevant.
Assert.Inconclusive("not implemented");
@DaveSkender DaveSkender merged commit 630bcdf into v3 Dec 16, 2024
11 checks passed
@DaveSkender DaveSkender deleted the 1095-auto-prune-in-memory-stream-data branch December 16, 2024 04:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

auto-prune in-memory stream data
1 participant