Merge pull request #46 from David032/32-exception-handling

32 Exception Handling
David032 · Feb 12, 2024 · 72711d5 · 72711d5
2 parents e8f5c18 + 2b78d67
commit 72711d5
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 8 deletions.
diff --git a/skullOS.Modules/Adventure.cs b/skullOS.Modules/Adventure.cs
@@ -1,6 +1,7 @@
 using skullOS.Core;
 using skullOS.HardwareServices;
 using skullOS.HardwareServices.Interfaces;
+using skullOS.Modules.Exceptions;
 using skullOS.Modules.Interfaces;
 using Timer = System.Timers.Timer;
 
@@ -34,12 +35,12 @@ private void TakePicture_Elapsed(object? sender, System.Timers.ElapsedEventArgs
 
         public override void OnAction(object? sender, EventArgs e)
         {
-            throw new NotImplementedException();
+            throw new OnActionException("Adventure does not support OnAction");
         }
 
         public override void OnEnable(string[] args)
         {
-            throw new NotImplementedException();
+            throw new OnEnableException("Adventure does not support OnEnable");
         }
 
         public override string ToString()

diff --git a/skullOS.Modules/Buzzer.cs b/skullOS.Modules/Buzzer.cs
@@ -1,4 +1,5 @@
 using skullOS.HardwareServices;
+using skullOS.Modules.Exceptions;
 using skullOS.Modules.Interfaces;
 using static skullOS.Modules.BuzzerLibrary;
 using static skullOS.Modules.BuzzerStructures;
@@ -34,11 +35,11 @@ public void PlayTune(Tunes tuneToPlay)
 
         public override void OnAction(object? sender, EventArgs e)
         {
-            throw new NotImplementedException();
+            throw new OnActionException("Buzzer does not support OnAction");
         }
         public override void OnEnable(string[] args)
         {
-            throw new NotImplementedException();
+            throw new OnEnableException("Buzzer does not support OnEnable");
         }
         public override string ToString()
         {

diff --git a/skullOS.Modules/Exceptions/OnActionException.cs b/skullOS.Modules/Exceptions/OnActionException.cs
@@ -0,0 +1,6 @@
+namespace skullOS.Modules.Exceptions
+{
+    public class OnActionException(string message) : Exception(message)
+    {
+    }
+}
diff --git a/skullOS.Modules/Exceptions/OnEnableException.cs b/skullOS.Modules/Exceptions/OnEnableException.cs
@@ -0,0 +1,6 @@
+namespace skullOS.Modules.Exceptions
+{
+    public class OnEnableException(string message) : Exception(message)
+    {
+    }
+}
diff --git a/skullOS.Modules/Prop.cs b/skullOS.Modules/Prop.cs
@@ -2,6 +2,7 @@
 using skullOS.Core;
 using skullOS.HardwareServices;
 using skullOS.HardwareServices.Interfaces;
+using skullOS.Modules.Exceptions;
 using System.Device.Pwm.Drivers;
 using Timer = System.Timers.Timer;
 
@@ -102,12 +103,12 @@ private async void FlapEar(bool useLeft = true)
 
         public override void OnAction(object? sender, EventArgs e)
         {
-            throw new NotImplementedException();
+            throw new OnActionException("Prop doesn't support OnAction");
         }
 
         public override void OnEnable(string[] args)
         {
-            throw new NotImplementedException();
+            throw new OnEnableException("Prop doesn't support OnEnable");
         }
         public override string ToString()
         {

diff --git a/skullOS.Modules/Support.cs b/skullOS.Modules/Support.cs
@@ -1,5 +1,6 @@
 using skullOS.HardwareServices;
 using skullOS.HardwareServices.Interfaces;
+using skullOS.Modules.Exceptions;
 using skullOS.Modules.Interfaces;
 using System.Device.Gpio;
 using Timer = System.Timers.Timer;
@@ -42,12 +43,12 @@ private void LowBatteryAlert_Elapsed(object? sender, System.Timers.ElapsedEventA
 
         public override void OnAction(object? sender, EventArgs e)
         {
-            throw new NotImplementedException();
+            throw new OnActionException("Support doesn't support OnAction");
         }
 
         public override void OnEnable(string[] args)
         {
-            throw new NotImplementedException();
+            throw new OnEnableException("Support doesn't support OnEnable");
         }
 
         public override string ToString()