Tools: metadata snippets parsing and validation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
reviewed
Dec 7, 2023
.tools/validation/validate.py
Outdated
Comment on lines
80
to
90
| for example in metadata: | ||
| for lang in example.languages: | ||
| language = example.languages[lang] | ||
| for version in language.versions: | ||
| for excerpt in version.excerpts: | ||
| for snippet_tag in excerpt.snippet_tags: | ||
| if snippet_tag not in snippets: | ||
| # Ensure all metadata snippets are found | ||
| errors.append( | ||
| MissingSnippet(file=example.file, tag=snippet_tag) | ||
| ) |
ford-at-aws
force-pushed
the
tools/metadata/dataclasses
branch
from
3c6d748 to
b5893e9
Compare
DavidSouther
force-pushed
the
tools/metadata/snippets
branch
from
958b028 to
e82d3df
Compare
DavidSouther
force-pushed
the
tools/metadata/snippets
branch
from
e82d3df to
a4ba0e8
Compare
github-actions
bot
added
CDK
DavidSouther
force-pushed
the
tools/metadata/snippets
branch
from
a4ba0e8 to
29889a1
Compare
github-actions
bot
removed
CDK
DavidSouther
force-pushed
the
tools/metadata/snippets
branch
from
29889a1 to
b149462
Compare
github-actions
bot
added
C++
DavidSouther
force-pushed
the
tools/metadata/snippets
branch
from
6f5061a to
f36b2bc
Compare
github-actions
bot
removed
C++
github-actions
bot
removed
Javascript-v3
DavidSouther
force-pushed
the
tools/metadata/snippets
branch
2 times, most recently
from
f15509d to
c0dcaba
Compare
* Rework error collection * Scan for snippet errors during validation
Service definition tweaks
rlhagerm
force-pushed
the
tools/metadata/snippets
branch
from
e3dadd4 to
ae5c815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings the snippet extractor into the public repo, and uses it to do more snippet validation during GHA.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.