Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message template to render #106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

prussyuval
Copy link

No description provided.

functions.js Outdated Show resolved Hide resolved
functions.js Outdated Show resolved Hide resolved
functions.js Outdated Show resolved Hide resolved
let message = '';
for (const obj of pr2user) {
switch (provider) {
case 'slack': {
const mention = github2provider[obj.login] ?
`<@${github2provider[obj.login]}>` :
`@${obj.login}`;
message += `Hey ${mention}, the PR "${obj.title}" is waiting for your review: ${obj.url}\n`;
message += messageTemplate.for
Copy link
Owner

@DavideViolante DavideViolante Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this messageTemplate.for? If messageTemplate is a string, .for throws a error

@DavideViolante
Copy link
Owner

Fix the linting using eslint
Fix the tests
Add more tests about this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants