Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pcaOtherPlotting.R #38

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

dkcoxie
Copy link
Contributor

@dkcoxie dkcoxie commented Jul 5, 2024

Updated plotPairPCA function to add argument for legend placement within ggpubr::ggarange() call.

Updated `plotPairPCA` function to add argument for legend placement within ggpubr::ggarange() call
Added missing comma from function arguments
@dkcoxie
Copy link
Contributor Author

dkcoxie commented Jul 5, 2024

The other plotting functions were easily updated using ggplot attributes but I had difficulties modifying the legend location for the paired PCA plots. Adding an argument passed to ggpubr::ggarange() for arranging the plots and removing the hard-coded legend position of "top" should resolve this.

I tested the changes to this function locally (by manually updating the function and loading in other called functions) and was able to generate the desired legend configurations.

@ningbioinfo
Copy link
Member

Thanks for the eidt. I'll commit the pull request.

Copy link
Member

@ningbioinfo ningbioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine.

@ningbioinfo ningbioinfo merged commit 8dd43b2 into DavisLaboratory:devel Aug 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants