Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can specify exit code when Autopilot lifespan expires. #105

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

Add the following settings to AutopilotSettings:

  • Exit Code (Choose enum)
  • Custom Exit Code (Integer value. Enabled if Exit Code is Custom)
  • Message

These settings will be used when the autopilot expires.

Note: I will also add the TerminateAgent that terminates the autopilot mid-scenario.

Priority

I hope to your review && merge around one week.
There is no need to release it yet.


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 16, 2024 12:53
@nowsprinting nowsprinting mentioned this pull request Nov 16, 2024
10 tasks
@nowsprinting nowsprinting mentioned this pull request Nov 17, 2024
1 task
@nowsprinting nowsprinting changed the title Can specify exit code when autopilot expires. Can specify exit code when Autopilot expires. Nov 17, 2024
@nowsprinting nowsprinting changed the title Can specify exit code when Autopilot expires. Can specify exit code when Autopilot lifespan expires. Nov 17, 2024
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit 44398ea into DeNA:master Nov 19, 2024
2 of 3 checks passed
@bo40
Copy link
Contributor

bo40 commented Nov 19, 2024

Thank you for your contribution!

@nowsprinting nowsprinting deleted the feature/exitcode_expire_lifespan branch November 19, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants