Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to reset instances when domain reloading is disabled #107

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

nowsprinting
Copy link
Contributor

Before

Not reset instance fields (not serialized) in ScriptableObjects when domain reloading is disabled.

After

Reset all instance fields (not serialized) in ScriptableObjects when even domain reloading is disabled.

Priority

I hope to your review && merge around one week.
There is no need to release it yet.


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 17, 2024 07:04
@github-actions github-actions bot added the fix label Nov 17, 2024
@nowsprinting nowsprinting changed the title Fix to reset instances when disabled domain reloading Fix to reset instances when domain reloading is disabled Nov 17, 2024
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit d52a58c into DeNA:master Nov 19, 2024
3 of 4 checks passed
@nowsprinting nowsprinting deleted the fix/reset_instances branch November 19, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants