Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to save converted assets #111

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

nowsprinting
Copy link
Contributor

@nowsprinting nowsprinting commented Nov 18, 2024

Before

An AutopilotSettings asset file is not saved when automatically converting obsolete fields.
However, the added asset files (e.g., SlackReporter) are generated.

After

Save AutopilotSettings asset file when automatically converting obsolete fields.

The obsolete fields have been cleared, and modify the log message.

Priority

I hope to your review && merge around one week.
There is no need to release it yet.


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 18, 2024 20:31
@github-actions github-actions bot added the chore label Nov 18, 2024
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bo40 bo40 merged commit a4f0e09 into DeNA:master Nov 19, 2024
3 of 4 checks passed
@nowsprinting nowsprinting deleted the chore/migration_tests branch November 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants