Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output files root path field into AutopilotSetings #115

Merged
merged 11 commits into from
Nov 25, 2024
Merged

Add output files root path field into AutopilotSetings #115

merged 11 commits into from
Nov 25, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Add fields into AutopilotSettings
    • outputRootPath
    • screenshotsPath
    • cleanScreenshots
  • Change output file root of relative path
    • FileLogger
    • JUnitXmlReporter
  • Change save screenshots path
    • UGUIEmergencyExitAgent
    • UGUIMonkeyAgent (obsolete screenshotDirectory field)
    • UGUIPlaybackAgent

Priority

I hope to your review && merge around one week.
There is no need to release it yet.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 24, 2024 12:03
@nowsprinting nowsprinting mentioned this pull request Nov 24, 2024
Closed
10 tasks
bo40
bo40 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your contribution!

@bo40 bo40 merged commit b9439ae into DeNA:master Nov 25, 2024
2 checks passed
@nowsprinting nowsprinting deleted the feature/output_root_directory branch November 25, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo40 bo40 bo40 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @bo40