Introduce customizable reporters #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Koji Hasegawa <[email protected]>
| @@ -108,19 +120,19 @@ msgid "Slack Mention Settings" | |||
| msgstr "Slackメンション設定" | |||
|
|
|||
| # mentionSubTeamIDs | |||
| msgid "Mention Sub Team IDs" | |||
| msgid "Sub Team IDs to Mention" | |||
There was a problem hiding this comment.
Since it is IDs, I interpreted that multiple IDs can be specified.
How do I specify multiple IDs for this?
There was a problem hiding this comment.
Comma-separated value is accepted. This is mentioned by the tooltip of this input. The input name should still be short because it should be readable if the display area is very tiny. So I mentioned about it by the tooltip, not the name.
nowsprinting
approved these changes
Nov 17, 2023
| return; | ||
| } | ||
|
|
||
| if (withScreenshot && !Application.isBatchMode) |
There was a problem hiding this comment.
IMO
There is a workaround for the batchmode problems.bellow:
using TestHelper.RuntimeInternals.Wrappers.UnityEditor
GameViewWrapper.GetWindow();
There was a problem hiding this comment.
I'm gonna try to use you suggested on another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make reporters customizable to users that using a communication tool that is not Slack.
Contribution License Agreement