-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support launch autopilot from Play Mode tests #36
Conversation
{ | ||
_logger.Log("Terminate autopilot"); | ||
_state.Reset(); | ||
_state.settings = null; | ||
_state.exitCode = exitCode; | ||
return; // Only terminate autopilot run if starting from play mode. | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nowsprinting Sorry for my late reply. Why launchFrom
does not get reset in here? I think this is a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed with a7f2c65
Fix regression about AutopilotState after terminate
- Revert to "reset AutopilotState in TerminateAsync"
- Changed throw NUnit.Framework.AssertionException to be during in the TerminateAsync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the autopilot run fails, the LogException will be output so that the test will fail.
I wrote a termination process just in case.
- Revert to "reset AutopilotState in TerminateAsync" - Changed throw NUnit.Framework.AssertionException to be during in the TerminateAsync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Usage
Autopilot works within your test code using the async method
LauncherFromTest.AutopilotAsync(string)
.Specify the
AutopilotSettings
file path as the argument.Note
If an error is detected in running, it will be output to
LogError
and the test will fail.Warning
The default timeout for tests is 3 minutes. If the autopilot execution time exceeds 3 minutes, please specify the timeout time with the
Timeout
attribute.Contribution License Agreement