Fix tests running on Linux editor #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: diff occur after running tests below: ``` - m_Name: DoNothingAgentForTests + m_Name: Observer ```
Tests failed with the following LogAssert output: ``` MonoScript is registered as both Editor and Runtime script! ```
After inserting `Assume.That` for investigation, the test no longer fails...
Kuniwak
reviewed
Apr 15, 2024
| @@ -57,6 +57,7 @@ public IEnumerator Launch_OnEditMode_RunAutopilotOnPlayMode() | |||
| editor.Launch(state); // Note: Can not call editor.OnInspectorGUI() and GUILayout.Button() | |||
|
|
|||
| yield return new WaitForDomainReload(); // Wait for domain reloading by switching play mode | |||
| Assume.That(EditorApplication.isPlaying, Is.True, "Switched to play mode"); | |||
Kuniwak
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and refactor tests
Contribution License Agreement