Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CreateDefaultLogger method to private #57

Merged

Conversation

nowsprinting
Copy link
Contributor

refs #52


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner May 11, 2024 04:36
@github-actions github-actions bot added the fix label May 11, 2024
Copy link
Member

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kuniwak Kuniwak merged commit 2858a2b into DeNA:master May 11, 2024
2 checks passed
@nowsprinting nowsprinting deleted the fix/createdefaultlogger_to_private branch May 11, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants