Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can overwrite error handling settings by command line arguments #63

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Can overwrite error handling settings by command line arguments #63

merged 2 commits into from
Jun 4, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Can overwrite error handling settings in command line arguments
    • -HANDLE_EXCEPTION
    • -HANDLE_ERROR
    • -HANDLE_ASSERT
    • -HANDLE_WARNING
  • Fix ArgumentCapture to testable

Contribution License Agreement

@nowsprinting nowsprinting marked this pull request as ready for review May 29, 2024 17:47
@nowsprinting nowsprinting requested a review from a team as a code owner May 29, 2024 17:47
@nowsprinting nowsprinting changed the title Can overwrite error handling settings in command line arguments Can overwrite error handling settings by command line arguments May 30, 2024
Kuniwak
Kuniwak approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late reply. LGTM.

@Kuniwak Kuniwak merged commit aaf61cf into DeNA:master Jun 4, 2024
2 checks passed
@nowsprinting nowsprinting deleted the feature/cli_errorhandling branch June 4, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuniwak Kuniwak Kuniwak approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @Kuniwak