Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ignore-messages can be specified by regex #67

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Make ignore-messages can be specified by regex #67

merged 3 commits into from
Sep 20, 2024

Conversation

nowsprinting
Copy link
Contributor

@nowsprinting nowsprinting commented Sep 16, 2024 •
edited
Loading

Changes

Make "Ignore Messages" can be specified by regex.

Priority

ASAP

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner September 16, 2024 20:38
asurato
asurato requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@asurato asurato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm in SWET.
I looked over the changes, and I commented.

README.md Outdated Show resolved Hide resolved
Tests/Runtime/Utilities/LogMessageHandlerTest.cs Show resolved Hide resolved
@nowsprinting
Copy link
Contributor Author

@asurato san, Thank you for your review!
I've fixed the recommendation, so please review it again!

asurato
asurato approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bo40
bo40 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato asurato merged commit d12d2ef into DeNA:master Sep 20, 2024
1 check passed
@nowsprinting nowsprinting deleted the feature/regex_ignore_message branch September 21, 2024 00:17
@nowsprinting nowsprinting mentioned this pull request Sep 21, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asurato asurato asurato approved these changes

@bo40 bo40 bo40 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nowsprinting @bo40 @asurato