Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile #71

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Fix Makefile #71

merged 2 commits into from
Sep 24, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Mod log file names to same to game-ci/unity-test-runner
  • Fix to code coverage exclude test project assemblies

Priority

It's a low priority for me.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner September 23, 2024 06:31
@github-actions github-actions bot added the chore label Sep 23, 2024
get-me-power
get-me-power approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@get-me-power get-me-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@get-me-power get-me-power merged commit 3b2a9db into DeNA:master Sep 24, 2024
2 checks passed
@get-me-power
Copy link
Member

@nowsprinting

Thanks for your contribution.

@nowsprinting nowsprinting deleted the chore/fix_makefile branch September 24, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@get-me-power get-me-power get-me-power approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @get-me-power