Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to work even when Time.timescale=0f #74

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix to work even when Time.timescale=0f #74

merged 2 commits into from
Oct 10, 2024

Conversation

nowsprinting
Copy link
Contributor

Problem

Fix the issue where UniTask.Delay does not work.
It remains UniTaskStatus.Pending when Time.timescale=0f.

Solutions

Priority

It's a low priority for me.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 10, 2024 01:46
@github-actions github-actions bot added the fix label Oct 10, 2024
@get-me-power get-me-power self-requested a review October 10, 2024 08:57
get-me-power
get-me-power approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@get-me-power get-me-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@get-me-power get-me-power merged commit 0696721 into DeNA:master Oct 10, 2024
2 checks passed
@get-me-power
Copy link
Member

@nowsprinting

Thanks for your contribution.

@nowsprinting nowsprinting deleted the fix/ignoretimescale branch October 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@get-me-power get-me-power get-me-power approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @get-me-power