Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EmergencyExit to EmergencyExitAnnotation #80

Merged

Conversation

nowsprinting
Copy link
Contributor

Changes

Change the naming rule of the annotation class name to the same as that of the test-helper.monkey.

see: https://github.com/nowsprinting/test-helper.monkey/tree/master/Annotations

Priority

It's a low priority for me.


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 21, 2024 08:47
@github-actions github-actions bot added the chore label Oct 21, 2024
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato asurato merged commit 0550148 into DeNA:master Oct 21, 2024
2 checks passed
@asurato
Copy link
Contributor

asurato commented Oct 21, 2024

@nowsprinting

Thank you for your contribution!

@nowsprinting nowsprinting deleted the chore/rename_emergency_exit_annotation branch October 21, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants