Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix description tooltip of Reporters #82

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix description tooltip of Reporters #82

merged 1 commit into from
Oct 28, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • s/logger/reporter/ in the description tooltip of Reporters
  • Move CompositeReporter in ja.po

refs #78

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 22, 2024 02:52
@github-actions github-actions bot added the fix label Oct 22, 2024
asurato
asurato approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit a80f516 into DeNA:master Oct 28, 2024
2 checks passed
@nowsprinting nowsprinting deleted the fix/reporter_desription_tooltip branch October 28, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asurato asurato asurato approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nowsprinting @asurato @bo40