Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous expressions and spelling variations #85

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • "project" to "game title"
    • Exclude: Unity project
  • "title" to "game title"
    • Exclude: Title scene
  • "game title own" to "game title specific" and some to "custom"

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 25, 2024 21:26
@github-actions github-actions bot added the fix label Oct 25, 2024
bo40
bo40 previously approved these changes Oct 28, 2024
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40
Copy link
Contributor

bo40 commented Oct 28, 2024

@nowsprinting
This PR has a conflict. Could you please resolve it?

Changes:

- "project" to "game title"
    - Exclude: Unity project
- "title" to "game title"
    - Exclude: Title scene
- "game title own" to "game title specific" and some to "custom"
@nowsprinting
Copy link
Contributor Author

@bo40 san, Rebased! Thank you.

@nowsprinting nowsprinting requested a review from bo40 October 28, 2024 06:33
@bo40 bo40 merged commit 005b168 into DeNA:master Oct 28, 2024
1 check passed
@bo40
Copy link
Contributor

bo40 commented Oct 28, 2024

Thank you!

@nowsprinting nowsprinting deleted the fix/document_expression branch October 28, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants