Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Loggers and Reporters support #92

Merged
merged 8 commits into from
Nov 1, 2024
Merged

Multiple Loggers and Reporters support #92

merged 8 commits into from
Nov 1, 2024

Conversation

nowsprinting
Copy link
Contributor

Before

  • Single Logger instance can be set to AutopilotSettings.loggerAsset field.
  • Single Reporter instance can be set to AutopilotSettings.reporter field.

After

  • Multiple Logger instances can be set to AutopilotSettings.loggerAssets field.
  • Multiple Reporter instances can be set to AutopilotSettings.reporters field.

Other Changes

  • Single Logger/ Reporter setting field is obsolete.
  • Converting legacy Logger/ Reporter settings to new multiple Loggers/ Reporters
  • Refactor initialize settings
  • Remove CompositeLogger/ Reporter from the context menu
  • Mod SlackReporter order in the context menu
  • Fix disabling Reset button

Priority

I hope to review && merge in this week.
There is no need to release it yet.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 31, 2024 00:53
@get-me-power get-me-power requested a review from asurato November 1, 2024 04:04
asurato
asurato previously approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato
Copy link
Contributor

asurato commented Nov 1, 2024

@nowsprinting
Will you resolve conflicts?

@nowsprinting
Copy link
Contributor Author

@asurato san, ok, please wait.

@nowsprinting nowsprinting force-pushed the feature/loggers_and_reporters branch from 66b59d1 to 021cebe Compare November 1, 2024 06:36
@nowsprinting
Copy link
Contributor Author

@asurato san, I completed rebase && tests!
Please merge it. Thank you!

@asurato asurato self-requested a review November 1, 2024 06:58
@asurato asurato merged commit 6c80729 into DeNA:master Nov 1, 2024
1 check passed
@asurato
Copy link
Contributor

asurato commented Nov 1, 2024

@nowsprinting
Thank you for your contribution!

@nowsprinting nowsprinting deleted the feature/loggers_and_reporters branch November 1, 2024 06:59
nowsprinting added a commit to nowsprinting/Anjin that referenced this pull request Nov 2, 2024
@nowsprinting
Fix using obsolete property
40156bc 
refs DeNA#92
nowsprinting added a commit to nowsprinting/Anjin that referenced this pull request Nov 4, 2024
@nowsprinting
Fix using obsolete property
f7b99b2 
refs DeNA#92
nowsprinting added a commit to nowsprinting/Anjin that referenced this pull request Nov 4, 2024
@nowsprinting
Fix using obsolete property
d1182db 
refs DeNA#92
nowsprinting added a commit to nowsprinting/Anjin that referenced this pull request Nov 5, 2024
@nowsprinting
Fix using obsolete property
18c97e7 
refs DeNA#92
@nowsprinting nowsprinting mentioned this pull request Nov 5, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asurato asurato asurato approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @asurato