Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix terminate process and player build failure #94

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Fix terminate process and player build failure #94

merged 3 commits into from
Nov 5, 2024

Conversation

nowsprinting
Copy link
Contributor

@nowsprinting nowsprinting commented Nov 2, 2024 •
edited
Loading

Fixes

  • Fix to Not cancel TeardownLaunchAutopilotAsync method on terminates
  • Fix using NUnit.Framework in runtime
  • Fix log exit code to integer value

Priority

I hope to review && merge ASAP (Tuesday onwards).
There is no need to release it yet.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 2, 2024 15:49
@github-actions github-actions bot added the fix label Nov 2, 2024
get-me-power
get-me-power approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@get-me-power get-me-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asurato
asurato approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato asurato merged commit b33861f into DeNA:master Nov 5, 2024
2 checks passed
@asurato
Copy link
Contributor

asurato commented Nov 5, 2024

@nowsprinting
Thank you for your contribution!

@nowsprinting nowsprinting deleted the fix/terminates branch November 5, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asurato asurato asurato approved these changes

@get-me-power get-me-power get-me-power approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nowsprinting @asurato @get-me-power