Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SceneCrossingAgents (ObserverAgent is obsolete) #97

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Add SceneCrossingAgents (ObserverAgent is obsolete) #97

merged 2 commits into from
Nov 6, 2024

Conversation

nowsprinting
Copy link
Contributor

@nowsprinting nowsprinting commented Nov 4, 2024 •
edited
Loading

Before

  • ObserverAgent can set a single Agent.
  • ObserverAgent is dispatched when loading any scene and disposes when unloading that scene.

After

  • Multiple agents can be set in SceneCrossingAgents.
  • SceneCrossingAgents will have the same lifespan as Autopilot (i.e., use DontDestroyOnLoad).

Priority

I hope to your review && merge around one week.
There is no need to release it yet.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 4, 2024 01:01
@nowsprinting nowsprinting force-pushed the feature/scene_crossing_agents branch from fdbea80 to 89f98d0 Compare November 5, 2024 10:54
@nowsprinting nowsprinting mentioned this pull request Nov 5, 2024
Closed
10 tasks
bo40
bo40 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

get-me-power
get-me-power approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@get-me-power get-me-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@get-me-power get-me-power merged commit eee4c84 into DeNA:master Nov 6, 2024
1 check passed
@nowsprinting nowsprinting deleted the feature/scene_crossing_agents branch November 6, 2024 07:14
nowsprinting added a commit to nowsprinting/Anjin that referenced this pull request Nov 6, 2024
@nowsprinting
Fix mistake rebase in DeNA#97
df7f5ce
@nowsprinting nowsprinting mentioned this pull request Nov 7, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@get-me-power get-me-power get-me-power approved these changes

@bo40 bo40 bo40 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nowsprinting @bo40 @get-me-power