Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JUnitXmlReporter #98

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Add JUnitXmlReporter (based on internal JUnitReporter class)
  • Remove junitReportPath from AutopilotSettings, and add convert to JUnitXmlReporter
  • Mod test-helper package version for running tests

Priority

I hope to your review && merge around one week.
There is no need to release it yet.


Contribution License Agreement

@nowsprinting nowsprinting marked this pull request as ready for review November 4, 2024 17:57
@nowsprinting nowsprinting requested a review from a team as a code owner November 4, 2024 17:57
nowsprinting added a commit to nowsprinting/Anjin that referenced this pull request Nov 4, 2024
@nowsprinting nowsprinting mentioned this pull request Nov 4, 2024
1 task
nowsprinting added a commit to nowsprinting/Anjin that referenced this pull request Nov 5, 2024
@nowsprinting nowsprinting force-pushed the feature/junit_reporter branch from 70cb121 to 1d9e6b4 Compare November 5, 2024 11:05
@nowsprinting nowsprinting mentioned this pull request Nov 5, 2024
10 tasks
@nowsprinting nowsprinting force-pushed the feature/junit_reporter branch from 1d9e6b4 to dbc3693 Compare November 6, 2024 07:25
@get-me-power
Copy link
Member

@nowsprinting

Runtime/Settings/AutopilotSettings.cs is conflicted.
Will you resolve conflicts?

@nowsprinting nowsprinting force-pushed the feature/junit_reporter branch from dbc3693 to ff6d24d Compare November 7, 2024 05:54
@nowsprinting
Copy link
Contributor Author

@get-me-power san, rebased!

@get-me-power get-me-power requested a review from asurato November 7, 2024 09:09
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I commented a little, LGTM.

Editor/UI/Reporters/JUnitXmlReporterEditor.cs Show resolved Hide resolved
Runtime/Reporters/JUnitXmlReporter.cs Show resolved Hide resolved
@asurato asurato merged commit c675058 into DeNA:master Nov 8, 2024
1 check passed
@asurato
Copy link
Contributor

asurato commented Nov 8, 2024

@nowsprinting
Thank you for your contribution!

@nowsprinting nowsprinting deleted the feature/junit_reporter branch November 8, 2024 04:03
@asurato
Copy link
Contributor

asurato commented Nov 8, 2024

@nowsprinting

Relative path from the project root directory. When run on player, relative path from the Application.persistentDataPath.

The latter sentence make sense slightly, but the structure of the sentence is broken.
Please consider to use Relative path from the project root directory or the Application.persistentDataPath in runs on player. if you see this comment.

@nowsprinting
Copy link
Contributor Author

Thanks, @asurato san,

Change the relative-path-root to "output root path field in AutopilotSetings", later.
This makes it easier to write.
However, I want to express that absolute paths can also be specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants