Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed debug information when target_tables is empty #11

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

meri025
Copy link
Contributor

@meri025 meri025 commented Jul 18, 2024

Summary

This pull request adds detailed debug information to the clean method of Cleaner to log the context when target_tables is empty. the following information will be logged when target_tables is empty:

  • The target tables (tables)
  • The except tables (@except_tables)
  • All tables in the database (all_tables)

If you find this change to be excessive, it is perfectly fine not to merge it.

Other Information

Checklist

@genya0407
Copy link
Contributor

I welcome the addition of detailed logs, as they are helpful in the investigation. However, it seems a bit tedious to add logs each time they are needed.

For example, I thought the following gem could be introduced to mysql_rewinder and your project to make the log output more comprehensive.
https://github.com/pboling/debug_logging/tree/v3.1.9

I will discuss this a bit later on my end.

@genya0407 genya0407 merged commit 16a9026 into DeNA:trunk Jul 19, 2024
10 checks passed
@meri025 meri025 deleted the update-log-message branch July 19, 2024 03:27
@genya0407 genya0407 mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants