Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review the custom editor sample #5

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

fredmerci
Copy link
Contributor

@fredmerci fredmerci commented Oct 30, 2024

En autres modifications, j'ai ajouté le tag 9.0.0 comme on en a parlé, mais est-ce indiqué pour ce sample ? (sachant qu'actuellement il faut utiliser l'image docker-eu.artifactory.swg-devops.com/hyc-odm-docker/odm:9.0.0-SNAPSHOT_24.1.0)
image: icr.io/cpopen/odm-k8s/odm:9.0.0

@fredmerci fredmerci requested a review from mmouly October 30, 2024 08:28
@mmouly
Copy link
Contributor

mmouly commented Oct 30, 2024

pour etre aligné avec guicustomization, est-ce que tu pourrais deplacer compose-odm-dev.yml dans le directory businessvalueeditor-source, stp ?
et dans la doc remplacer :
"docker-compose -f ../compose-odm-dev.yml up odm"
par
"docker-compose -f compose-odm-dev.yml up odm &"

editer compose-odm-dev.yml
remplacer :
- $PWD/businessvalueeditor-source/target/businessvalueeditor-1.0.jar:/config/download/businessvalueeditor-1.0.jar
- $PWD/businessvalueeditor-source/web.xml:/config/download/web.xml

par
- $PWD/target/businessvalueeditor-1.0.jar:/config/download/businessvalueeditor-1.0.jar
- $PWD/web.xml:/config/download/web.xml

@mmouly
Copy link
Contributor

mmouly commented Oct 30, 2024

faudrait recuperer aussi le secret.baseline 8bb634e

@fredmerci
Copy link
Contributor Author

fredmerci commented Oct 30, 2024

je ne pense pas que cela soit nécessaire. Tu as déjà fait le nécessaire dans la branche main et le fichier .secret.baseline ne devrait pas être écrasé lors du merge de cette PR car il est plus récent

@fredmerci fredmerci merged commit 3fcc919 into main Oct 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants