-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add tutorials for PPIs #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great tutorials!
I think the main comment I have is that I would split up the zotero into two separate repo's. One for pdb data and another for hdf5 data. People going through data generation don't need to download 2GB, especially because almost all of it will be deleted in the 1st step anyway.
The HDF5 repo is the only for people that don't want to go through the process of data generation (actually, that one can just be the current one, with all data because the pdbs don't add much).
Apart from that, these are mostly some minor textual suggestions and in a few places make some of the settings more explicit/visible so that users see how/where to find them.
Just to be sure, if you can give a fast look to the new edits, then I can merge :) |
If you'll review this PR again when I am on holiday, feel free to merge it if there is nothing else to add @DaniBodor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
I fixed a few remaining typos/language issues in the notebooks, apart from that it looks good!
I agree with your point about publishing it with a finished run, so people could choose to gloss over it instead of running the notebook. If we do it that way, I think we should state that they can either gloss or clear the notebook and run it themselves. Shall I add a comment about that and run the notebooks, or do you prefer to leave them blank? Or do you think this will prompt too many users to just read and not try it out themselves?
Also, I noticed that you left code snippets of the neural networks inside the md cells. I still think it's quite distracting from the flow to have such a large code block in the middle of a cell for something that is non-essential to understand at a basic level how to run the software. Did you have a particular reason for leaving it or did you miss my previous comment on this?
Regarding Zenodo. Maybe a nice idea to already add a .gitignore file with *
in each folder, just to make extra sure that no data inside is tracked. (this is especially useful in case people save the data in a different location than the recommended one). Also, remove the Mac leftovers (DS_Store thing).
Finally, should there be some explanation of how to use notebooks at all (or at least a link explaining it)? Especially for users who don't use notebooks integrated in their IDE, it would be nice to be able to run it from jupyter-lab (like we do for the workshops). Maybe there could be a README for the notebooks specifically, with the generic info like intro and install instructions that is currently on top of both notebooks (then it doesn't need to be repeated), as well as how to use it from IDE or jupyter-lab. I did a draft of this in PR #455 , see if you like it or not.
I made some changes in (mainly to README) in #452 that are pointing here, because I branched off from here to avoid conflicts in the future. That one can either be merged to this first, or can be merged to main after this goes through.
Give me a sign when you merge the other two PRs (#455 and #452), if there is nothing else to add I'll merge this then :) @DaniBodor |
Co-authored-by: Giulia Crocioni <[email protected]>
Co-authored-by: Giulia Crocioni <[email protected]>
Co-authored-by: Giulia Crocioni <[email protected]>
Co-authored-by: Giulia Crocioni <[email protected]>
Co-authored-by: Giulia Crocioni <[email protected]>
docs: create tutorial README
docs: improve installation instructions
It might make sense to wait for #446 to get closed before finalizing this, so we can include those changes (otherwise it can be updated in that PR). |
With this PR, I add two tutorial notebooks for PPI data;
data_generation_ppi.ipynb
training_ppi.ipynb
GraphDatasets
GridDatasets