fix: test_cuda in test_trainer.py::TestTrainer
#572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [readthedocs-sphinx-search](https://github.com/readthedocs/readthedocs-sphinx-search) from 0.1.1 to 0.3.2. - [Changelog](https://github.com/readthedocs/readthedocs-sphinx-search/blob/main/CHANGELOG.rst) - [Commits](readthedocs/readthedocs-sphinx-search@0.1.1...0.3.2) --- updated-dependencies: - dependency-name: readthedocs-sphinx-search dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…-sphinx-search-0.3.2 Bump readthedocs-sphinx-search from 0.1.1 to 0.3.2 in /docs
docs: add RSD badge
gcroci2
changed the title
test_trainer.py::TestTrainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
tests/test_trainer.py::TestTrainer::test_cuda, we were not setting cuda correctly - not using theuse_cudaparameter in the test.We were also asserting that data tensors are cuda tensors, but this is never true since the data are transferred to the GPU device only during the training when iterating over the Dataloader instances (see line 705 of trainer.py).