Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: restore PyPI installation #611

Merged
merged 17 commits into from
Jun 20, 2024
Merged

CI: restore PyPI installation #611

merged 17 commits into from
Jun 20, 2024

Conversation

gcroci2
Copy link
Collaborator

@gcroci2 gcroci2 commented Jun 17, 2024

In this PR:

  • I removed all the pip installable packages from the deeprank.yml and I moved them back into the pyproject.toml file. This way they will be package together with the package on pip, and pip install deeprank2 will take care of installing them all.
  • I found a way for installing pip packages within the env defined in the dockerfile. After this PR will be merged, I will do a new pip release (which will contain the pip dependencies) and I'll delete the deeprank2-docker.yml and requirements-docker.txt files, since they are not needed anymore (I will pip install deeprank2 together with its pip dependencies in the dockerfile).
  • No need to update the instructions for the installation.

@gcroci2 gcroci2 linked an issue Jun 17, 2024 that may be closed by this pull request
6 tasks
@coveralls
Copy link

Coverage Status

coverage: 83.933%. remained the same
when pulling c0c77f3 on remove_conda_deps
into 73969e6 on main.

@coveralls
Copy link

Coverage Status

coverage: 83.818% (-0.1%) from 83.933%
when pulling ee08b3a on remove_conda_deps
into 73969e6 on main.

@coveralls
Copy link

Coverage Status

coverage: 83.933%. remained the same
when pulling 28afabe on remove_conda_deps
into 73969e6 on main.

@coveralls
Copy link

Coverage Status

coverage: 83.933%. remained the same
when pulling 8403245 on remove_conda_deps
into 73969e6 on main.

@coveralls
Copy link

Coverage Status

coverage: 83.818% (-0.1%) from 83.933%
when pulling 56929ff on remove_conda_deps
into 73969e6 on main.

@coveralls
Copy link

Coverage Status

coverage: 83.933%. remained the same
when pulling 289719a on remove_conda_deps
into 73969e6 on main.

@gcroci2 gcroci2 mentioned this pull request Jun 20, 2024
6 tasks
@coveralls
Copy link

Coverage Status

coverage: 83.933%. remained the same
when pulling 90a6c06 on remove_conda_deps
into 73969e6 on main.

@coveralls
Copy link

Coverage Status

coverage: 83.818% (-0.1%) from 83.933%
when pulling 0ca24d2 on remove_conda_deps
into 73969e6 on main.

@gcroci2 gcroci2 requested a review from DaniBodor June 20, 2024 12:39
@gcroci2 gcroci2 changed the base branch from main to dev June 20, 2024 12:45
@gcroci2 gcroci2 merged commit 375053b into dev Jun 20, 2024
5 checks passed
@gcroci2 gcroci2 deleted the remove_conda_deps branch June 20, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda migration
3 participants