Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make dependencies versions more reliable #616

Merged
merged 18 commits into from
Jul 9, 2024
Merged

build: make dependencies versions more reliable #616

merged 18 commits into from
Jul 9, 2024

Conversation

gcroci2
Copy link
Collaborator

@gcroci2 gcroci2 commented Jun 20, 2024 •
edited
Loading

This PR:

  • Fixes versions for critical dependencies (e.g., PyTorch) and use version ranges for less critical ones (e.g., numpy).
  • Adds a freezed env file up-to-date with the latest versions working of the various packages and an action for testing it.

@gcroci2 gcroci2 changed the base branch from main to dev June 20, 2024 14:33
@gcroci2 gcroci2 linked an issue Jun 20, 2024 that may be closed by this pull request
Manage/set dependencies versions #607
Closed
2 tasks
@gcroci2 gcroci2 closed this Jun 20, 2024
@gcroci2 gcroci2 reopened this Jun 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

This PR is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale issue not touched from too much time label Jul 8, 2024
@gcroci2 gcroci2 requested a review from DaniBodor July 9, 2024 08:48
@gcroci2 gcroci2 removed the stale issue not touched from too much time label Jul 9, 2024
DaniBodor
DaniBodor approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to provide the frozen environment as well.
Can you change "freezed" to "frozen" throughout the PR, please.

.github/actions/install-python-and-package/action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@DaniBodor
Copy link
Collaborator

DaniBodor commented Jul 9, 2024 •
edited
Loading

there's also the build-repo-freezed-env.yml file where the name isn't updated yet :)

@gcroci2 gcroci2 merged commit 6206f15 into dev Jul 9, 2024
7 checks passed
@gcroci2 gcroci2 deleted the set_deps_versions branch July 9, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniBodor DaniBodor DaniBodor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage/set dependencies versions
2 participants
@gcroci2 @DaniBodor