Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pixelswap totalVolume and dailyVolume #1938

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

amching
Copy link
Contributor

@amching amching commented Sep 24, 2024

pixel-swap totalVolume and dailyVolume

@llamatester
Copy link

The pixelswap adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs pixelswap

🦙 Running PIXELSWAP adapter 🦙
---------------------------------------------------
Start Date:	Mon, 23 Sep 2024 00:00:00 GMT
End Date:	Tue, 24 Sep 2024 00:00:00 GMT
---------------------------------------------------

TON 👇
Backfill start time: 11/9/2024
NO METHODOLOGY SPECIFIED
Daily volume: 0
Total volume: 1266.59 B

@dtmkeng
Copy link
Contributor

dtmkeng commented Sep 25, 2024

seem Total volume is so high could you check ?

@llamatester
Copy link

The pixelswap adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs pixelswap

🦙 Running PIXELSWAP adapter 🦙
---------------------------------------------------
Start Date:	Wed, 25 Sep 2024 00:00:00 GMT
End Date:	Thu, 26 Sep 2024 00:00:00 GMT
---------------------------------------------------

TON 👇
Backfill start time: 11/9/2024
NO METHODOLOGY SPECIFIED
Daily volume: 86.86 k
Total volume: 8685896.08 B

@llamatester
Copy link

The pixelswap adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs pixelswap

🦙 Running PIXELSWAP adapter 🦙
---------------------------------------------------
Start Date:	Wed, 25 Sep 2024 00:00:00 GMT
End Date:	Thu, 26 Sep 2024 00:00:00 GMT
---------------------------------------------------

TON 👇
Backfill start time: 11/9/2024
NO METHODOLOGY SPECIFIED
Daily volume: 9.87 M
Total volume: 187203286281.62 B

@dtmkeng
Copy link
Contributor

dtmkeng commented Sep 26, 2024

still incorrect

@amching
Copy link
Contributor Author

amching commented Oct 9, 2024

Calculating volume includes the transaction volume from adding and removing liquidity, which results in a very large total transaction volume.

@dtmkeng
Copy link
Contributor

dtmkeng commented Oct 9, 2024

Total volume: 187203286281.62 B

Total volume: 187203286281.62 B is so large it think it is incorrect

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculating volume includes the transaction volume from adding and removing liquidity, which results in a very large total transaction volume.

yeah, you exclude it then? from both daily volume and total volume. We consider only swap volume

Now the volume is swap, deposit and withdraw(We have funding contract, which other Dex doesn't have funding contract, so the volume add deposit and withdraw)
@llamatester
Copy link

The pixelswap adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs pixelswap

🦙 Running PIXELSWAP adapter 🦙
---------------------------------------------------
Start Date:	Thu, 10 Oct 2024 00:00:00 GMT
End Date:	Fri, 11 Oct 2024 00:00:00 GMT
---------------------------------------------------

TON 👇
Backfill start time: 11/9/2024
NO METHODOLOGY SPECIFIED
Daily volume: 389
Total volume: 21.01 k

@dtmkeng dtmkeng merged commit 1e5a204 into DefiLlama:master Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants