CloudStorage

[d2hydro]

Cloud class for #32

[visr]

Pushed a commit and left some comments.

[visr]

I see you convert to Path in __post_init__. Can't we not drop the Union here and make sure it is Path from the start?

I prefer to be less flexible to keep this code as simple as possible.

[d2hydro]

1. From the user-perspective; most readers accept Path and str-type paths; e.g. gpd.read_file(Path("my_file.shp")) and gpd.read_file("my_file.shp") both work.
2. It will be a string (or None) if users do or do not supply RIBASIM_NL_DATA_DIR or the data_dir at __init__

   Ribasim-NL/src/ribasim_nl/ribasim_nl/cloud.py

   Line 76 in a3aa8b8

   if self.data_dir is None:

[visr]

Yeah I'm not saying we should not accept strings from the user, just that in our class it seemed like it would be easier if we convert it at the door to this class. But I don't directly have a suggestion how to do this, so feel free to ignore.

[visr]

Why not use Path.is_dir()? I don't think we need this function.

[d2hydro]

Is used in

Ribasim-NL/src/ribasim_nl/ribasim_nl/cloud.py

Line 250 in a3aa8b8

if is_dir(item):

. Path("my_dir").is_dir() is only True if path is directory ánd the directory exists. If you have better code, please provide.

[visr]

Ah ok it wasn't clear to me that this should be true if the directory doesn't exist. Would be good to clarify in a docstring.

[visr]

Should we perhaps use this: https://github.com/fsspec/universal_pathlib?

[d2hydro]

Should we perhaps use this: https://github.com/fsspec/universal_pathlib?

Cool, let's do it later?

[visr]

Would be good to add the is_dir docstring, otherwise this can be merged. I made #35 for possible follow-up improvements.

[visr]

Suggested change

	Import the `Cloud`` and initialize it
	Import the `CloudStorage` and initialize it