postgres 16/python 3.12

[chris48s]

This PR looks like it is changing a lot of files but if you ignore the formatting changes in

• 6c8b372
• 98caa30

it is not too bad.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.81%. Comparing base (5129aac) to head (06ec515).
Report is 16 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files          28       28           
  Lines         568      568           
=======================================
  Hits          442      442           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chris48s]

Wow. Pipenv makes it really hard to upgrade only one package in the lockfile these days

• ValueError: The flag --selective-upgrade flag has been removed
• ValueError: The flag --keep-outdated flag has been removed
• --lock-only exists, but the doesn't do what it says it will ( Why --lock-only flag logic removed? pypa/pipenv#6131 )

[chris48s]

Question: How can I check this on dev?

[chris48s]

OK, so I tested a deploy (I've now reverted that commit).

Interestingly, this application seems to only have production and staging. There's a "Dev - Website - DC" AWS account, but it doesn't seem to have anything in it and the development branch triggers a deploy to staging

Website/.circleci/config.yml

Lines 145 to 151 in 5129aac

	- sam_deploy:
	name: sam_deploy_staging
	dc-environment: staging
	requires:
	- sam_build
	context: [ deployment-staging-dc-website, slack-secrets ]
	filters: { branches: { only: [ main, master, development ] } }

so anyway I've checked it on stage.DC.

Other things

RDS

This application lives on an RDS instance which is shared with some other things. Namely

• aggregator-api-production
• dc-website-production
• listmonk
• wcivf_feedback_production

so we have to be in a position where we want to migrate all of those before we upgrade it. Might be useful to catch up on that tomorrow

Safety CI

Currently, Safety CI is failing because there is a RCE in setuptools <70 GHSA-cx63-2mw6-8hw5 but dc_django_utils is pinning us to setuptools==69.2.0. https://github.com/DemocracyClub/dc_django_utils/blob/43ec52d2846b1b28cfaabd036841456c5f9a4466/pyproject.toml#L13 So that requires some cross-repo work to get the build passing and unblock this.

Aside from that I think this one is ready for review though. I reckon it is worth reviewing what is here accepting that the build is failing and it is not merge-able until we fix or ignore that safety error.