Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing and remove unused code #257

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Add testing and remove unused code #257

wants to merge 19 commits into from

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented Sep 26, 2024 •
edited
Loading

  • Added Playwright tests for the front-end leaflet upload process.
  • Replaced TestCase with pytest for testing.
  • Introduced YNR API key to bypass rate limiting.
  • Resolved security vulnerability by upgrading Django from 4.2.15 to 4.2.16.
  • Updated CI configuration to fix persistent issues with Pipenv.
  • Add overall test coverage
  • Misc bug fixes

TO DO:

64c4e85 includes local dev changes that were needed to work on this PR but will be introduced in #259 (comment)

@VirginiaDooley VirginiaDooley changed the base branch from master to upgrades202409-part2 September 26, 2024 15:27
@VirginiaDooley VirginiaDooley changed the base branch from upgrades202409-part2 to master September 26, 2024 15:30
@VirginiaDooley VirginiaDooley changed the base branch from master to upgrades202409-part2 September 26, 2024 15:31
@VirginiaDooley VirginiaDooley changed the base branch from upgrades202409-part2 to master September 26, 2024 15:39
@VirginiaDooley VirginiaDooley changed the base branch from master to upgrades202409-part2 September 26, 2024 15:53
@VirginiaDooley VirginiaDooley force-pushed the hotfix/fix-staging-uploads branch 2 times, most recently from cc6d803 to e4e2edf Compare September 30, 2024 13:42
@VirginiaDooley VirginiaDooley force-pushed the upgrades202409-part2 branch 5 times, most recently from 21b3792 to 5f8cebb Compare October 1, 2024 12:29
Base automatically changed from upgrades202409-part2 to master October 1, 2024 13:58
@VirginiaDooley VirginiaDooley force-pushed the hotfix/fix-staging-uploads branch 3 times, most recently from 9551458 to 38adb43 Compare October 2, 2024 14:14
@VirginiaDooley VirginiaDooley changed the title Hotfix/fix staging uploads Test frontend with Playwright Oct 2, 2024
@VirginiaDooley VirginiaDooley force-pushed the hotfix/fix-staging-uploads branch 11 times, most recently from 421dfdf to 15c41cd Compare October 8, 2024 21:38
@VirginiaDooley
Test frontend uploads with playwright
a58ecee 
- Install and configure playwright
- Includes README.md with helpful playwright commands
- Add basic upload and nav tests
@VirginiaDooley
WIP playwright for TestCase
3072ac9
@VirginiaDooley
Updated Pipfile.lock
92837e9
@VirginiaDooley
Handle cases where no initial date exists:
2a382c4
@VirginiaDooley
Request YNR with auth_token
90a0e49
@VirginiaDooley
Handle exceptions in the party importer
3239cb6
@VirginiaDooley
Test redirect after leaflet creation
71ac720
@VirginiaDooley
Address vulnerability in Django=4.2.15; Bump to 4.2.16
c440c69
@VirginiaDooley
Fix pillow install
8f39e24
@VirginiaDooley
Install and use pytest
6a09101
@VirginiaDooley
WIP Convert tests to use pytest
2a5f650
@VirginiaDooley
Return a relative path to address path traversal attempt
87aa369
@VirginiaDooley
Convert image_editing tests from TestCase to pytest
2817d10
@VirginiaDooley
Remove unused code
8967662
@VirginiaDooley
Saving an LeafletImage requires an image file and name
7153e4b
@VirginiaDooley
WIP adjust tests after asking pytest to use testing.py
f150446 
I think this change is required following the change to
use pytest and testing.py settings that use the `test_media`
path for sourcing test images.
@VirginiaDooley VirginiaDooley changed the title Test frontend with Playwright Add testing and remove unused code Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VirginiaDooley