Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dc utils and basic auth middleware #2440

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

awdem
Copy link

@awdem awdem commented Oct 1, 2024


@awdem awdem force-pushed the adds-dc_utils-and-basic-auth-middleware branch from 04da841 to 72ca1d9 Compare October 1, 2024 12:43
# Allowlist of URLs that should be ignored by dc_utils BasicAuthMiddleware
BASIC_AUTH_ALLOWLIST = [
"/api",
"/api/*",
Copy link
Member

@chris48s chris48s Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being an EC2-based app, YNR does have a healthcheck endpoint.

Annoyingly the load balancer just calls / rather than a dedicated endpoint so we would need to allow that but if we deployed this as-is, we'd go into a loop of:

  • bring up a new instance
  • the load balancer decides it is unhealthy and shuts it down
  • bring up a new instance

..and so on.

Given we are probably parking this until we actually have a staging site, maybe lets not not bogged down but I did just want to note that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants