Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add github-green-purple theme #251

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

pushpak-256
Copy link
Contributor

@pushpak-256 pushpak-256 commented Jun 12, 2022

This theme is suitable for dark theme github, with green purple colors and white text for info.

Description

Fixes #

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

  • Tested with a valid username
  • Tested with an invalid username

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation

Screenshots

image

@DenverCoder1
Copy link
Owner

Thanks, in order to support the theme, you'll need to add it to themes.php. Please see issue #32 for details.

You probably want to copy the entry for chartreuse-dark to the end of the file and replace CurrStreakNum and CurrStreakLabel with #800080

Also, the docs should have a static image for example,

https://user-images.githubusercontent.com/20955511/173238945-f572fdfb-dbf6-4141-8ee6-b70f6186548e.png

This theme  is suitable for dark theme github, with green purple colors and white text for info.
@pushpak-256
Copy link
Contributor Author

pushpak-256 commented Jun 12, 2022

  • Was trying to run this app locally by installing php , to get img, but having some troubles
  • But, Ive updated things that you asked

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title 🎨 Add github-green-purple theme feat: Add github-green-purple theme Jun 12, 2022
@DenverCoder1 DenverCoder1 merged commit 99dff1c into DenverCoder1:main Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants