Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Hebrew translations and RTL language support #335

Merged
merged 3 commits into from
Oct 16, 2022

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented Oct 15, 2022

Description

Adds Hebrew translations and RTL language support

Thanks u/CherryPepper_1 on Reddit for help with the translation

image

Ref: #236

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-rtl-hebrew-iuz4ta October 15, 2022 00:21 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-rtl-hebrew-iuz4ta October 16, 2022 01:29 Inactive
@DenverCoder1 DenverCoder1 marked this pull request as ready for review October 16, 2022 01:30
@DenverCoder1 DenverCoder1 merged commit 6c18585 into main Oct 16, 2022
@DenverCoder1 DenverCoder1 deleted the rtl-hebrew branch October 16, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant