[Logic Improvement] Enable notifications for the first iteration of the scanner when the state is empty #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this first iteration of the scanner, the
self.state
variable is initialized as an empty dictionary and only populated after the first notification command is executed. This means that in the initial scan, notifications are not sent for magic bags already available in the TGTG application.Since the second scan does not detect changes (if no new magic bags are added), no notifications are sent for the already available magic bags.
To address this, I propose a minor logic improvement by initializing the
self.state
variable before the first notification command is triggered.Additionally, to pass the pre-commit checks, I ran
poetry lock
to update dependencies, aspoetry lock --no-update
was unsuccessful. The app continues to run smoothly with these changes.