Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasets info for tests #303

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

vs9h
Copy link
Collaborator

@vs9h vs9h commented Nov 27, 2023

In this pull request, a datasets info file has been added, which should contain information about all datasets in order to avoid code duplication in each test file.
It is important to note that this pull request does not aim to unify all test files, but is limited to only a part of the tests (namely fd and ucc).
In the future it can also be used in other tests.

Also fixed dataset info for abalone.csv: has_header true -> false

@vs9h vs9h requested a review from polyntsov November 27, 2023 19:27
@vs9h vs9h force-pushed the add-datasets-info branch 4 times, most recently from 984c912 to de7f408 Compare November 28, 2023 09:36
@vs9h vs9h mentioned this pull request Nov 28, 2023
@vs9h vs9h force-pushed the add-datasets-info branch from de7f408 to c1f87a5 Compare November 30, 2023 11:13
@vs9h vs9h changed the title Refactoring in hash-based tests Add datasets info for tests Dec 3, 2023
@vs9h vs9h force-pushed the add-datasets-info branch 2 times, most recently from 55b2eb3 to 4f04a14 Compare December 4, 2023 18:11
src/tests/datasets.h Outdated Show resolved Hide resolved
src/tests/datasets.h Outdated Show resolved Hide resolved
src/tests/test_fd_util.h Show resolved Hide resolved
src/tests/datasets.h Outdated Show resolved Hide resolved
src/tests/datasets.h Outdated Show resolved Hide resolved
src/tests/all_datasets_info.h Outdated Show resolved Hide resolved
@vs9h vs9h force-pushed the add-datasets-info branch 2 times, most recently from ac4a35f to ceaf8cd Compare December 4, 2023 22:53
@vs9h vs9h requested a review from polyntsov December 4, 2023 22:55
@vs9h vs9h force-pushed the add-datasets-info branch 3 times, most recently from 826374c to 3b50d9c Compare December 5, 2023 19:47
@vs9h vs9h force-pushed the add-datasets-info branch from 3b50d9c to 913d73b Compare December 5, 2023 19:54
@vs9h vs9h merged commit 4978ff7 into Desbordante:main Dec 5, 2023
20 checks passed
@vs9h vs9h deleted the add-datasets-info branch December 5, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants